diff options
| author | Matthew Barnes <mbarnes@redhat.com> | 2013-02-08 20:03:26 +0800 |
|---|---|---|
| committer | Matthew Barnes <mbarnes@redhat.com> | 2013-02-08 20:03:26 +0800 |
| commit | 6ba0a6a95bc68ea6bb49b4b2d623e3ea60ba6d79 (patch) | |
| tree | ec63b01e51834492c41ce996398631c7c68fa7e5 /libemail-engine | |
| parent | 2b507716b257e6ef98dae8463180dbe718eb7b64 (diff) | |
| download | gsoc2013-evolution-6ba0a6a95bc68ea6bb49b4b2d623e3ea60ba6d79.tar gsoc2013-evolution-6ba0a6a95bc68ea6bb49b4b2d623e3ea60ba6d79.tar.gz gsoc2013-evolution-6ba0a6a95bc68ea6bb49b4b2d623e3ea60ba6d79.tar.bz2 gsoc2013-evolution-6ba0a6a95bc68ea6bb49b4b2d623e3ea60ba6d79.tar.lz gsoc2013-evolution-6ba0a6a95bc68ea6bb49b4b2d623e3ea60ba6d79.tar.xz gsoc2013-evolution-6ba0a6a95bc68ea6bb49b4b2d623e3ea60ba6d79.tar.zst gsoc2013-evolution-6ba0a6a95bc68ea6bb49b4b2d623e3ea60ba6d79.zip | |
Revert "Bug #683867 - Schedule actions with higher idle priority"
This reverts commit 2b507716b257e6ef98dae8463180dbe718eb7b64.
The commit contains not a single comment as to why these custom priority
values are being used. The rationale needs to be documented in the code,
either at each call point or preferrably at a centralized priority value
definition.
Diffstat (limited to 'libemail-engine')
| -rw-r--r-- | libemail-engine/e-mail-utils.c | 2 | ||||
| -rw-r--r-- | libemail-engine/mail-folder-cache.c | 4 | ||||
| -rw-r--r-- | libemail-engine/mail-mt.c | 10 |
3 files changed, 8 insertions, 8 deletions
diff --git a/libemail-engine/e-mail-utils.c b/libemail-engine/e-mail-utils.c index 17e61365db..5e9a6db853 100644 --- a/libemail-engine/e-mail-utils.c +++ b/libemail-engine/e-mail-utils.c @@ -824,7 +824,7 @@ free_mail_cache_thread (gpointer user_data) e_cancellable_mutex_unlock (&photos_cache_lock); } - g_idle_add_full (G_PRIORITY_HIGH, free_mail_cache_idle, user_data, NULL); + g_idle_add (free_mail_cache_idle, user_data); return NULL; } diff --git a/libemail-engine/mail-folder-cache.c b/libemail-engine/mail-folder-cache.c index f1af370b1e..35e620862e 100644 --- a/libemail-engine/mail-folder-cache.c +++ b/libemail-engine/mail-folder-cache.c @@ -304,8 +304,8 @@ flush_updates (MailFolderCache *cache) if (g_queue_is_empty (&cache->priv->updates)) return; - cache->priv->update_id = g_idle_add_full (G_PRIORITY_DEFAULT, - (GSourceFunc) flush_updates_idle_cb, cache, NULL); + cache->priv->update_id = g_idle_add ( + (GSourceFunc) flush_updates_idle_cb, cache); } /* This is how unread counts work (and don't work): diff --git a/libemail-engine/mail-mt.c b/libemail-engine/mail-mt.c index 3ff5242344..baf1476f82 100644 --- a/libemail-engine/mail-mt.c +++ b/libemail-engine/mail-mt.c @@ -216,7 +216,7 @@ mail_msg_unref (gpointer msg) /* Destroy the message from an idle callback * so we know we're in the main loop thread. */ - g_idle_add_full (G_PRIORITY_DEFAULT, (GSourceFunc) mail_msg_free, mail_msg, NULL); + g_idle_add ((GSourceFunc) mail_msg_free, mail_msg); } } @@ -429,8 +429,8 @@ mail_msg_proxy (MailMsg *msg) G_LOCK (idle_source_id); if (idle_source_id == 0) - idle_source_id = g_idle_add_full (G_PRIORITY_DEFAULT, - (GSourceFunc) mail_msg_idle_cb, NULL, NULL); + idle_source_id = g_idle_add ( + (GSourceFunc) mail_msg_idle_cb, NULL); G_UNLOCK (idle_source_id); } @@ -484,8 +484,8 @@ mail_msg_main_loop_push (gpointer msg) G_LOCK (idle_source_id); if (idle_source_id == 0) - idle_source_id = g_idle_add_full (G_PRIORITY_DEFAULT, - (GSourceFunc) mail_msg_idle_cb, NULL, NULL); + idle_source_id = g_idle_add ( + (GSourceFunc) mail_msg_idle_cb, NULL); G_UNLOCK (idle_source_id); } |