From d3e0f96c73dde49acde92f6347b9e362d85e94aa Mon Sep 17 00:00:00 2001 From: Matthew Barnes Date: Tue, 29 Oct 2013 09:28:17 -0400 Subject: Fix error handling glitch in mail_session_send_to_thread(). If sending a message fails but the user was already connected to the MTA, the error is missed and not handled until further into the logic, where it's treated as though sending succeeded and only post-processing failed. This results in the user seeing a copy of the message in Sent, but the message was never actually sent. Fallout from the investigation of bug 710807. --- libemail-engine/e-mail-session-utils.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'libemail-engine/e-mail-session-utils.c') diff --git a/libemail-engine/e-mail-session-utils.c b/libemail-engine/e-mail-session-utils.c index da39b54ff3..41a9a4d47f 100644 --- a/libemail-engine/e-mail-session-utils.c +++ b/libemail-engine/e-mail-session-utils.c @@ -578,11 +578,11 @@ mail_session_send_to_thread (GSimpleAsyncResult *simple, camel_service_disconnect_sync ( context->transport, TRUE, cancellable, &error); } + } - if (error != NULL) { - g_simple_async_result_take_error (simple, error); - return; - } + if (error != NULL) { + g_simple_async_result_take_error (simple, error); + return; } skip_send: -- cgit v1.2.3