From 18c08853768cc4cae9125aaf185268b90a0f23cf Mon Sep 17 00:00:00 2001 From: Tor Lillqvist Date: Sat, 26 Nov 2005 03:51:16 +0000 Subject: Use g_get_tmp_dir() instead of hardcoding /tmp. 2005-11-26 Tor Lillqvist * e-menu.c (emph_construct_menu): Use g_get_tmp_dir() instead of hardcoding /tmp. * e-util.c (e_strstrcase): Use g_ascii_strncasecmp() instead of the deprecated g_strncasecmp(). What kinds of strings this function is supposed to be used on (UTF-8 or some random single- or multi-byte encoding) is anybody's guess. This function isn't used in Evolution and should probably go away, though. And this is one of the files that have a partially duplicated copy in e-d-s/libedataserver, too, so doubly so. (e_filename_make_safe): Mark more bytes as unsafe on Win32. Add comments. This function is really under-specified and weird, one wonders whether it really does what the author thought it should do. (fsync): Add Win32 implementation of fsync(). * e-xml-utils.c (e_xml_get_bool_prop_by_name_with_default): Use g_ascii_strcasecmp() instead of the deprecated g_strcasecmp(), especially as we are comparing to literal ASCII strings. svn path=/trunk/; revision=30684 --- e-util/e-xml-utils.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) (limited to 'e-util/e-xml-utils.c') diff --git a/e-util/e-xml-utils.c b/e-util/e-xml-utils.c index 4f919fcacd..5ac741a278 100644 --- a/e-util/e-xml-utils.c +++ b/e-util/e-xml-utils.c @@ -44,10 +44,6 @@ #include "e-util.h" #include "e-xml-utils.h" -#ifdef G_OS_WIN32 -#define fsync(fd) 0 /* No fsync() in Microsoft's C library */ -#endif - xmlNode * e_xml_get_child_by_name (const xmlNode *parent, const xmlChar *child_name) { @@ -316,9 +312,9 @@ e_xml_get_bool_prop_by_name_with_default(const xmlNode *parent, prop = xmlGetProp ((xmlNode *) parent, prop_name); if (prop != NULL) { - if (g_strcasecmp (prop, "true") == 0) { + if (g_ascii_strcasecmp (prop, "true") == 0) { ret_val = TRUE; - } else if (g_strcasecmp (prop, "false") == 0) { + } else if (g_ascii_strcasecmp (prop, "false") == 0) { ret_val = FALSE; } xmlFree(prop); -- cgit v1.2.3