From 8cfdad88c98a0e7a7f09e7ae07cff451a9c6cce4 Mon Sep 17 00:00:00 2001 From: Jeffrey Stedfast Date: Mon, 26 Jul 2004 21:24:20 +0000 Subject: Don't instantiate an engine here. Instead, take an engine as an argument 2004-07-26 Jeffrey Stedfast * providers/imap4/camel-imap4-store.c (connect_to_server): Don't instantiate an engine here. Instead, take an engine as an argument (it has a service pointer) and connect using that. Also, if connect fails, don't unref the engine. (connect_to_server_wrapper): Now also takes an engine argument rather than a service argument. (imap4_try_authenticate): Now also takes an engine argument. (imap4_connect): Pass the engine to connect/auth functions rather than the store. (imap4_query_auth_types): Updated. (imap4_disconnect): Don't unref the engine here. (camel_imap4_store_init): Create the engine here. (imap4_get_folder_info): Can't check engine == NULL to know to connect (that was a broken check anyway). * providers/imap4/camel-imap4-engine.c (camel_imap4_engine_new): Now simply takes a service argument rather than a session and url. (camel_imap4_engine_next_token): Set the state to DISCONNECTED. (camel_imap4_engine_eat_line): Same. (camel_imap4_engine_line): Same. (camel_imap4_engine_literal): Same. svn path=/trunk/; revision=26740 --- camel/ChangeLog | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) (limited to 'camel/ChangeLog') diff --git a/camel/ChangeLog b/camel/ChangeLog index 3f01cd49c7..d8862c2f2d 100644 --- a/camel/ChangeLog +++ b/camel/ChangeLog @@ -1,3 +1,27 @@ +2004-07-26 Jeffrey Stedfast + + * providers/imap4/camel-imap4-store.c (connect_to_server): Don't + instantiate an engine here. Instead, take an engine as an argument + (it has a service pointer) and connect using that. Also, if + connect fails, don't unref the engine. + (connect_to_server_wrapper): Now also takes an engine argument + rather than a service argument. + (imap4_try_authenticate): Now also takes an engine argument. + (imap4_connect): Pass the engine to connect/auth functions rather + than the store. + (imap4_query_auth_types): Updated. + (imap4_disconnect): Don't unref the engine here. + (camel_imap4_store_init): Create the engine here. + (imap4_get_folder_info): Can't check engine == NULL to know to + connect (that was a broken check anyway). + + * providers/imap4/camel-imap4-engine.c (camel_imap4_engine_new): + Now simply takes a service argument rather than a session and url. + (camel_imap4_engine_next_token): Set the state to DISCONNECTED. + (camel_imap4_engine_eat_line): Same. + (camel_imap4_engine_line): Same. + (camel_imap4_engine_literal): Same. + 2004-07-22 Not Zed ** See bug #61761. -- cgit v1.2.3