From af40da7d0ffb40515bc785bf95dbc85f439d35b2 Mon Sep 17 00:00:00 2001 From: Matthew Barnes Date: Fri, 3 Sep 2010 08:18:19 -0400 Subject: Bug 628653 - e_alert_new_valist memory leak --- e-util/e-alert.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/e-util/e-alert.c b/e-util/e-alert.c index aebee8326a..e4e698fae7 100644 --- a/e-util/e-alert.c +++ b/e-util/e-alert.c @@ -529,8 +529,11 @@ e_alert_new (const gchar *tag, ...) EAlert * e_alert_new_valist (const gchar *tag, va_list ap) { + EAlert *alert; + GPtrArray *args; gchar *tmp; - GPtrArray *args = g_ptr_array_new_with_free_func (g_free); + + args = g_ptr_array_new_with_free_func (g_free); tmp = va_arg (ap, gchar *); while (tmp) { @@ -538,7 +541,11 @@ e_alert_new_valist (const gchar *tag, va_list ap) tmp = va_arg (ap, gchar *); } - return e_alert_new_array (tag, args); + alert = e_alert_new_array (tag, args); + + g_ptr_array_unref (args); + + return alert; } EAlert * -- cgit v1.2.3