From 5cffe63121e4d1f21b2ed628bcd96f084fef412e Mon Sep 17 00:00:00 2001 From: Milan Crha Date: Mon, 22 Jul 2013 12:03:55 +0200 Subject: Do not mask CAMEL_ERROR_GENERIC in composer_send_completed() Any provider can return a generic error code, which makes the check useless, only hiding important error information from a user. Since the camel_getaddrinfo() returns CAMEL_SERVICE_ERROR_URL_INVALID, the check could be adapted and be more useful. --- mail/em-composer-utils.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/mail/em-composer-utils.c b/mail/em-composer-utils.c index 1980ac902c..d8d9eb7496 100644 --- a/mail/em-composer-utils.c +++ b/mail/em-composer-utils.c @@ -523,9 +523,10 @@ composer_send_completed (GObject *source_object, g_error_matches ( local_error, CAMEL_SERVICE_ERROR, CAMEL_SERVICE_ERROR_UNAVAILABLE) || - /* XXX camel_getaddrinfo() sets this, unfortunately. */ + /* a name resolution failed */ g_error_matches ( - local_error, CAMEL_ERROR, CAMEL_ERROR_GENERIC); + local_error, CAMEL_SERVICE_ERROR, + CAMEL_SERVICE_ERROR_URL_INVALID); if (service_unavailable) { /* Inform the user. */ e_alert_run_dialog_for_args ( -- cgit v1.2.3