Fix/mute issues found by Coverity scan

This makes the code free of Coverity scan issues.
It is sometimes quite pedantic and expects/suggests some
coding habits, thus certain changes may look weird, but for a good
thing, I hope. The code is also tagged with Coverity scan
suppressions, to keep the code as is and hide the warning too.
Also note that Coverity treats g_return_if_fail(), g_assert() and
similar macros as unreliable, and it's true these can be disabled
during the compile time, thus it brings in other set of 'weird'
changes.

1 files changed, 8 insertions, 3 deletions

diff --git a/shell/e-shell-migrate.c b/shell/e-shell-migrate.c
index 20e96960e4..f7de962fde 100644
--- a/shell/e-shell-migrate.c
+++ b/shell/e-shell-migrate.c
@@ -19,12 +19,15 @@
  *
  */
 
-#include "e-shell-migrate.h"
-
+#ifdef HAVE_CONFIG_H
 #include <config.h>
+#endif
+
+#include <errno.h>
 #include <glib/gstdio.h>
 #include <libedataserver/libedataserver.h>
 
+#include "e-shell-migrate.h"
 #include "evo-version.h"
 
 static gboolean
@@ -157,7 +160,9 @@ change_dir_modes (const gchar *path)
 		g_free (full_path);
 	}
 
-	g_chmod (path, 0700);
+	if (g_chmod (path, 0700) == -1)
+		g_warning ("%s: Failed to chmod of '%s': %s", G_STRFUNC, path, g_strerror (errno));
+
 	g_dir_close (dir);
 }