diff options
| author | Matthew Barnes <mbarnes@redhat.com> | 2013-10-29 21:28:17 +0800 |
|---|---|---|
| committer | Matthew Barnes <mbarnes@redhat.com> | 2013-10-29 21:28:17 +0800 |
| commit | d3e0f96c73dde49acde92f6347b9e362d85e94aa (patch) | |
| tree | d177014b1ee3e98a2e8394b87e6508453fc99c43 | |
| parent | 1e40668551b1822518feb3e9433dd1c0179598c8 (diff) | |
| download | gsoc2013-evolution-d3e0f96c73dde49acde92f6347b9e362d85e94aa.tar gsoc2013-evolution-d3e0f96c73dde49acde92f6347b9e362d85e94aa.tar.gz gsoc2013-evolution-d3e0f96c73dde49acde92f6347b9e362d85e94aa.tar.bz2 gsoc2013-evolution-d3e0f96c73dde49acde92f6347b9e362d85e94aa.tar.lz gsoc2013-evolution-d3e0f96c73dde49acde92f6347b9e362d85e94aa.tar.xz gsoc2013-evolution-d3e0f96c73dde49acde92f6347b9e362d85e94aa.tar.zst gsoc2013-evolution-d3e0f96c73dde49acde92f6347b9e362d85e94aa.zip | |
Fix error handling glitch in mail_session_send_to_thread().
If sending a message fails but the user was already connected to the
MTA, the error is missed and not handled until further into the logic,
where it's treated as though sending succeeded and only post-processing
failed. This results in the user seeing a copy of the message in Sent,
but the message was never actually sent.
Fallout from the investigation of bug 710807.
| -rw-r--r-- | libemail-engine/e-mail-session-utils.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/libemail-engine/e-mail-session-utils.c b/libemail-engine/e-mail-session-utils.c index da39b54ff3..41a9a4d47f 100644 --- a/libemail-engine/e-mail-session-utils.c +++ b/libemail-engine/e-mail-session-utils.c @@ -578,11 +578,11 @@ mail_session_send_to_thread (GSimpleAsyncResult *simple, camel_service_disconnect_sync ( context->transport, TRUE, cancellable, &error); } + } - if (error != NULL) { - g_simple_async_result_take_error (simple, error); - return; - } + if (error != NULL) { + g_simple_async_result_take_error (simple, error); + return; } skip_send: |